Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ‘rows' attribute to the textarea, with a default value of 2 rows. #665

Merged
merged 6 commits into from
Nov 14, 2024

Conversation

guoxinghuang
Copy link
Contributor

Add ‘rows' attribute to the textarea, with a default value of 3 rows.

lib/backpex/fields/textarea.ex Outdated Show resolved Hide resolved
@guoxinghuang guoxinghuang changed the title Add ‘rows' attribute to the textarea, with a default value of 3 rows. Add ‘rows' attribute to the textarea, with a default value of 2 rows. Nov 13, 2024
@Flo0807
Copy link
Collaborator

Flo0807 commented Nov 13, 2024

Can you add row to the list of options (on top of the Backpex.Fields.Textarea module) with a brief description? @guoxinghuang

@Flo0807 Flo0807 added the enhancement Changes that are not breaking label Nov 13, 2024
@guoxinghuang
Copy link
Contributor Author

Docs, done. @Flo0807

@Flo0807 Flo0807 merged commit 9088586 into naymspace:develop Nov 14, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Changes that are not breaking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants